-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move swing related stuff out of runtime package into org.antlr.v4.gui #955
Conversation
only issue might be that org.antlr.v4.runtime.misc.TestRig is how you run the command-line grammar tester but now it's org.antlr.v4.gui.TestRig. maybe the answer is to alter the PR so that the package names are absolutely the same but would just be included with a different jar |
I think we have enough confusion surrounding TestRig for beginners already. I think keeping the same exact name is a very good idea. |
closing and rebuilding. |
The other option here is doing what you have, but leaving a shim TestRig in the runtime in the same place it is now. The shim TestRig in the runtime would:
📝 Compared to this PR, implementing this option would only require the addition of the shim |
interesting. ok, pushing new version that says:
or
if you have full jar. No warning if org.antlr.v4.gui.TestRig called. |
Fixes #576 |
move swing related stuff out of runtime package into org.antlr.v4.gui
👍 |
Fixes #576