Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move swing related stuff out of runtime package into org.antlr.v4.gui #955

Merged
merged 3 commits into from
Jul 15, 2015

Conversation

parrt
Copy link
Member

@parrt parrt commented Jul 14, 2015

Fixes #576

@parrt
Copy link
Member Author

parrt commented Jul 14, 2015

only issue might be that org.antlr.v4.runtime.misc.TestRig is how you run the command-line grammar tester but now it's org.antlr.v4.gui.TestRig. maybe the answer is to alter the PR so that the package names are absolutely the same but would just be included with a different jar

@sharwell
Copy link
Member

only issue might be that org.antlr.v4.runtime.misc.TestRig is how you run the command-line grammar tester but now it's org.antlr.v4.gui.TestRig. maybe the answer is to alter the PR so that the package names are absolutely the same but would just be included with a different jar

I think we have enough confusion surrounding TestRig for beginners already. I think keeping the same exact name is a very good idea.

@parrt
Copy link
Member Author

parrt commented Jul 14, 2015

closing and rebuilding.

@parrt parrt closed this Jul 14, 2015
@sharwell
Copy link
Member

The other option here is doing what you have, but leaving a shim TestRig in the runtime in the same place it is now. The shim TestRig in the runtime would:

  1. Attempt to locate the new TestRig in the classpath, and if that fails print a message that the tool jar must now be available if you want to run test rig.
  2. If the new TestRig is found, print a message that TestRig has moved and the new one is being called automatically, then call its main() with the same arguments.

📝 Compared to this PR, implementing this option would only require the addition of the shim TestRig class in the runtime library.

@parrt
Copy link
Member Author

parrt commented Jul 14, 2015

interesting. ok, pushing new version that says:

Use of TestRig now requires the use of the tool jar, antlr-4.X-complete.jar
Maven users need group ID org.antlr and artifact ID antlr4

or

Warning: TestRig moved to org.antlr.v4.gui.TestRig; calling automatically

if you have full jar. No warning if org.antlr.v4.gui.TestRig called.

@parrt parrt reopened this Jul 14, 2015
@parrt
Copy link
Member Author

parrt commented Jul 15, 2015

Fixes #576

parrt added a commit that referenced this pull request Jul 15, 2015
move swing related stuff out of runtime package into org.antlr.v4.gui
@parrt parrt merged commit b555099 into antlr:master Jul 15, 2015
@sharwell
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants