Describe workaround for recent Docker Desktop mishap #27354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent Docker Desktop (4.13.0) introduced a breaking (seriously) change for new users where /var/run/docker.sock is removed. They will likely restore it as result of backlash docker/for-mac#6529 (comment) but this change adds check and workaround that such users might apply. Related to: apache#27217
dstandish
approved these changes
Oct 28, 2022
ephraimbuddy
approved these changes
Oct 28, 2022
| Docker Desktop released late October 2022 (4.13.0) has ``/var/run/docker.sock`` removed. | ||
| If you install 4.13.0 for the first time you will miss ``/var/run/docker.sock`` and you will get | ||
| "docker is not running" error. This was done too hastily and they are likely to | ||
| `remove it <https://github.com/docker/for-mac/issues/6529#issuecomment-1292135881i>`_ in the |
There was a problem hiding this comment.
Suggested change
| `remove it <https://github.com/docker/for-mac/issues/6529#issuecomment-1292135881i>`_ in the | |
| `add it back <https://github.com/docker/for-mac/issues/6529#issuecomment-1292135881i>`_ in the |
| If you install 4.13.0 for the first time you will miss ``/var/run/docker.sock`` and you will get | ||
| "docker is not running" error. This was done too hastily and they are likely to | ||
| `remove it <https://github.com/docker/for-mac/issues/6529#issuecomment-1292135881i>`_ in the | ||
| next patchlevel, but if you happen to see "docker is not running" when it is, you should not have |
There was a problem hiding this comment.
Suggested change
| next patchlevel, but if you happen to see "docker is not running" when it is, you should not have | |
| next patchlevel. If you happen to see "docker is not running" when it is, you may not have |
potiuk
deleted the
describe-workaround-for-recent-docker-desktop-mishap
branch
|
ah .. too fast. missed jed's comments |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 29, 2022
potiuk
added a commit
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Docker Desktop (4.13.0) introduced a breaking (seriously) change for new users where /var/run/docker.sock is removed.
They will likely restore it as result of backlash
docker/for-mac#6529 (comment) but this change adds check and workaround that such users might apply.
Related to: #27217
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.