-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MENFORCER-411] DependencyConvergence takes include/exclude parameters to filter errors #136
[MENFORCER-411] DependencyConvergence takes include/exclude parameters to filter errors #136
Conversation
c49d941
to
cf23701
Compare
…s to filter errors
cf23701
to
1f7340f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fdfea Thanks for your PR
- simple comments to code
- I will happy to see options with only
excludes
without declaring emptyincludes
- please rebase code with the latest master
Please select one of checkbox about licence to acknowledge your contribution under AFS licence
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/utils/DependencyVersionMap.java
Outdated
Show resolved
Hide resolved
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/utils/DependencyVersionMap.java
Outdated
Show resolved
Hide resolved
maven-enforcer-plugin/src/it/projects/dependency-convergence_exclude_failure/invoker.properties
Outdated
Show resolved
Hide resolved
Hi, I see that this hasnt been changed in a long time. Are there any plans on having this brought up again and possibly merged ? Im specially looking into ways of excudling tests deps from the dep convergence analysis and I hope that this change would be of great help. |
72c4c22
to
6b38a24
Compare
e322900
to
872d648
Compare
872d648
to
d1ff1d7
Compare
Hi @slawekjaranowski , I forgot about this PR. Thanks for taking a look at it. I've addressed your comments and rebased with master. Please take another look when you get a chance. Do I need to sign a contributor agreement for this or will checking the "I hereby declare..." checkbox suffice? |
Hi @fdfea please rebase and resolve conflicts. |
@slawekjaranowski Updated |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MENFORCER-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.