Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-427: Read initial ACK on channel open prior to direct stream upload & close streams prior to exit code handling #464

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

TerraNibble
Copy link
Contributor

@TerraNibble TerraNibble commented Feb 9, 2024

Fixes GH-427.

  • Ensures that the initial ACK sent upon creating the channel is processed prior to sending the payload stream.
  • Channel IO streams are first closed to trigger EOF prior to handling the exit code.
  • DefaultScpClient.upload(InputStream local, ...) no longer hits exit status timeout (5 seconds by default) on each invocation.
  • This can be observed by running ScpTest.testStreamsUploadAndDownload.

@TerraNibble TerraNibble changed the title GH-427: Read initial ACK on channel open prior to direct stream upload GH-427: Read initial ACK on channel open prior to direct stream upload & close streams prior to exit code handling Feb 9, 2024
@tomaswolf tomaswolf merged commit e754db9 into apache:master Apr 27, 2024
@tomaswolf tomaswolf added this to the 2.13.0 milestone Apr 27, 2024
@tomaswolf tomaswolf removed this from the 2.13.0 milestone May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultScpClient.upload(InputStream, ...) will always hit the exit status timeout
2 participants