[fix] Fix comment for ConnectionMaxIdleTime #1091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default value of
ConnectionMaxIdleTime
is said to be 60 seconds in the comment,pulsar-client-go/pulsar/client.go
Lines 155 to 157 in 2a15a25
but it actually seems to be 180 seconds. 60 seconds is the minimum value, not the default value.
pulsar-client-go/pulsar/client_impl.go
Lines 39 to 40 in 2a15a25
Verifying this change