Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix comment for ConnectionMaxIdleTime #1091

Merged

Conversation

massakam
Copy link

@massakam massakam commented Sep 11, 2023

Motivation

The default value of ConnectionMaxIdleTime is said to be 60 seconds in the comment,

// Release the connection if it is not used for more than ConnectionMaxIdleTime.
// Default is 60 seconds, negative such as -1 to disable.
ConnectionMaxIdleTime time.Duration

but it actually seems to be 180 seconds. 60 seconds is the minimum value, not the default value.

defaultConnMaxIdleTime = 180 * time.Second
minConnMaxIdleTime = 60 * time.Second

Verifying this change

  • Make sure that the change passes the CI checks.

@massakam massakam added this to the v0.12.0 milestone Sep 11, 2023
@massakam massakam self-assigned this Sep 11, 2023
@RobertIndie RobertIndie merged commit f979c18 into apache:master Sep 13, 2023
6 checks passed
@massakam massakam deleted the fix-ConnectionMaxIdleTime-comment branch September 14, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants