Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: factor out prepareTransaction #1118

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Oct 24, 2023

This refers to #1071. This follows to #1117.

  • Factor out prepareTransaction method.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@tisonkun tisonkun changed the title refactor: factor out prepareTransaction and partially unify sendRequest.done refactor: factor out prepareTransaction Oct 24, 2023
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun merged commit 1b135f4 into apache:master Oct 24, 2023
6 checks passed
@tisonkun tisonkun deleted the pretxn branch October 24, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants