SAMZA-2801: fix the case when waterrmark is not aggregated when quorum is not met #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous pr #1705 adds the support of preventing watermark stall during lagging upstream tasks. In testing we found a bug introduced by the logic that the aggregated watermark is not advancing if the smallest watermark have been updated, but the updated tasks within the idle timeout doesn't meet quorum. The fix is to keep the previous logic if the aggregated watermark has advanced, otherwise invoking the logic for computing quorum.
Also changed the quorum count to be a metric instead of logging, due to the potential large number of logs.