Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json. Bump chart.js version to 2.7.3 #433

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

gofreddo
Copy link
Contributor

Update package.json. Bump chart.js version to 2.7.3.

We're using vue-chartjs in a web component. Shadow DOM support was added in Version 2.7.3 chartjs/Chart.js#5585 .

Fix or Enhancement?

  • All tests passed

Environment

  • OS: Write here
  • NPM Version: Write here

Update package.json.  Bump chart.js version to 2.7.3.  

We're using vue-chartjs in a web component.   Shadow DOM support was added in Version 2.7.3 chartjs/Chart.js#5585 .
@apertureless
Copy link
Owner

Well, ... I don't really get this PR. 🤔

Chart.js is only a peerDependecy. It does not ship together with vue-chartjs.

Thats the reason why you need to install both. So as you have to install chart.js by yourself you are free to use any version you want.

You changed only the devDependency, which has no effect for the published build.

@gofreddo
Copy link
Contributor Author

gofreddo commented Nov 7, 2018

True. I was mistaken. It doesn't hurt to bump the dev version though.

@apertureless apertureless merged commit 6698767 into apertureless:develop Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants