Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential problem #3176

Closed
zoelner opened this issue Mar 20, 2018 · 5 comments
Closed

Credential problem #3176

zoelner opened this issue Mar 20, 2018 · 5 comments

Comments

@zoelner
Copy link

zoelner commented Mar 20, 2018

Hello, I'm having trouble with the credentials option. I'm running Tutorial, tried setting it up to 'include', but when I run it, it's always set to 'same-origin'. Am I doing something wrong?

Error

@natorojr
Copy link

natorojr commented Mar 23, 2018

Same issue here. This effectively renders Apollo Boost unusable if you're using cookie-based authentication with a server on a different sub-domain (e.g., www.example.com hitting api.example.com).

@cmatheson
Copy link

I'm seeing the same problem with everything in fetchOptions (the headers I pass are ignored and some default value is used).

@10thfloor
Copy link

Looks like the problem could be this?
https://github.com/apollographql/apollo-client/blob/master/packages/apollo-boost/src/index.ts#L76

credentials: 'same-origin' is not being overridden by the fetchOptions object.

@abhiaiyer91
Copy link
Contributor

Made a PR for this here: #3464

@hwillson
Copy link
Member

Addressed in #3098. Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants