Allow apollo-boost to support headers and credentials

[rzane]

Apollo Boost should allow you to pass in headers and credentials. Currently credentials is hardcoded to same-origin and it's not possible to set request headers.

[apollo-cla]

@rzane: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[peggyrayzis]

Hi @rzane! Thanks for making this PR. Since you can already configure headers and credentials, I'm not going to merge this.

You can set headers and credentials either statically by passing them as fetchOptions or dynamically by setting them on the context of the operation with the request function. Does that make sense?

[rzane]

Hi @peggyrayzis, I'm pretty confident that static headers can't be passed through fetchOptions. The HTTP link appears to ignore them.

I've created a repro of that issue here: https://gist.github.com/rzane/d6691acf7d4a60dd3a31389ced72b6de

To demonstrate the problem, run the following commands:

$ git clone git@gist.github.com:d6691acf7d4a60dd3a31389ced72b6de.git apollo-boost-repro && \
    cd apollo-boost-repro && \
    yarn install && \
    yarn start

[sgrove]

We're also running same behavior with apollo-boost specifically and can't quite figure out how to work around it. Setting either custom headers or credentials in fetchOptions seems to be ignored.

[zoelner]

The line that writes header settings Apollo Bost L77

[rzane]

@peggyrayzis, can we reopen this PR?

[tyscorp]

@peggyrayzis this is still broken and makes apollo-boost completely unusable for a lot (most?) users.

Re-opened PR

[tzvc]

What's the update on this guys ? Static headers still can't be passed through fetchOptions

[hwillson]

@theochampion This will be merged shortly. There is still some work to do here with regards to testing, but I'm planning on having it done today (which means it will be in next Tuesday's release).

[hwillson]

We should be all set here - thanks for kickstarting this PR @rzane!

[thecodejack]

@hwillson any idea when this is expected to be in any of release tag?

[hwillson]

@thecodejack We're releasing a new version later today! 🙂

[rares-lupascu]

i waited the entire day for the new version ... is it yesterday or still today?

[thecodejack]

@hwillson i don't see the release..can we expect still the release later today?

[hwillson]

@wowzaaa @thecodejack Sorry, yesterday 💯% got away from me! apollo-client 2.3.3 is now published. Thanks!

[thecodejack]

Thanks ..it is helping 👍

[alexkrolick]

These should probably have been part of fetchOptions, right? That's the way it's documented.

[antenando]

I have lost a night trying to figure this out. It is simply in the wrong place...
Since the beginning I was inserting it inside fetchOptions.... 😡

[engbrianlee]

I also had this issue, the documentation should be clear to place credentials in the root and not fetchOptions as if placed in fetchOptions it will be overwritten by the root credentials whicih defaults to 'same-origin'

[thiagomgd]

Just had the same problem today... =/