-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExecutionResult of graphql v15 not compatible with apollo-client types #6125
Comments
Looks like the peerDependencies state that these are not compatible: So this is basically a request to support graphql 15 |
then this is related to #6111 |
Addressed by #6194 and available in the latest |
FYI graphql-js has updated their types and added the generic back, with a default value now: graphql/graphql-js#2626 |
Intended outcome:
When for example defining an
update
function onuseMutation
, the parametermutationResult
is defined asFetchResult<T>
. I expect therefore to receive a type ofFetchResult<MyType>
.Actual outcome:
mutationResult
isany
This is due to some changes in graphql v15, where they removed the generic type from
ExecutionResult
.graphql/graphql-js#2490
How to reproduce the issue:
Versions
"apollo": "2.26.0",
"apollo-cache-inmemory": "^1.6.3",
"apollo-client": "^2.6.4",
"apollo-link": "^1.2.13",
"graphql": "^15.0.0",
System:
OS: macOS 10.15.4
Binaries:
Node: 12.16.1 - ~/.nvm/versions/node/v12.16.1/bin/node
Yarn: 1.22.4 - ~/Development/akb-kupa-arbeitsplatz/node_modules/.bin/yarn
npm: 6.13.4 - ~/.nvm/versions/node/v12.16.1/bin/npm
Browsers:
Chrome: 80.0.3987.163
Firefox: 74.0
Safari: 13.1
The text was updated successfully, but these errors were encountered: