fix: bug where query is stuck on loading if final chunk contains only hasNext: false
#10735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly hasNext: false
🦋 Changeset detectedLatest commit: 30f6726 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…al-key-stuck-loading
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…k-loading' of github.com:apollographql/apollo-client into issue-10406-deferred-chunk-with-no-incremental-key-stuck-loading
alessbell
changed the title
hasNext: false
alessbell
deleted the
issue-10406-deferred-chunk-with-no-incremental-key-stuck-loading
branch
Merged
alessbell
restored the
issue-10406-deferred-chunk-with-no-incremental-key-stuck-loading
branch
|
/release:pr |
|
A new release has been made for this PR. You can install it with |
alessbell
deleted the
issue-10406-deferred-chunk-with-no-incremental-key-stuck-loading
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10406.
The Router implemented a
@deferspec proposal update in how it handles deferred responses that point to an element that was nullified inv1.6.0that caused one of our client E2E tests that tested non-null errors thrown outside of deferred fragments to begin failing.What was previously a final chunk of
{"hasNext":false,"incremental":[{"data":null, path:...}]}now returns{"hasNext":false}, without anincrementalkey.The web client was not prepared to handle final chunks containing only
{hasNext: false}despite it being a valid payload, and the result is a permanentloading: truestate. This fix ensures that if a chunk indicates it is the final one without anyincrementaldata, the observable is completed.Tested the fix with the E2E test repo:
Checklist: