Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce export type for all type-level exports. #11115

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Conversation

phryneas
Copy link
Member

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

This was triggered by my review over in #11112 - seems we were only enforcing that for import statements, but not for export statements.

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2023

🦋 Changeset detected

Latest commit: ce6e69f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.16 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.73 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 42.33 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.39 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.22 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.21 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.2 KB (0%)
import { useQuery } from "dist/react/index.js" 4.29 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.1 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.6 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.42 KB (0%)
import { useMutation } from "dist/react/index.js" 2.53 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.51 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.24 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.2 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 4.71 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.14 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.2 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.63 KB (0%)
import { useReadQuery } from "dist/react/index.js" 2.69 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.67 KB (0%)
import { useFragment } from "dist/react/index.js" 2.08 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.03 KB (0%)

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 89fb8d7
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/64c79c36f66ff100080d65c4
😎 Deploy Preview https://deploy-preview-11115--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is mostly a plea to keep formatting where it was before, just with the types/values separated. Thanks for getting this updated!

src/cache/index.ts Outdated Show resolved Hide resolved
src/cache/index.ts Outdated Show resolved Hide resolved
src/core/index.ts Outdated Show resolved Hide resolved
src/core/index.ts Outdated Show resolved Hide resolved
src/link/http/index.ts Outdated Show resolved Hide resolved
src/utilities/index.ts Outdated Show resolved Hide resolved
src/utilities/index.ts Outdated Show resolved Hide resolved
src/utilities/index.ts Outdated Show resolved Hide resolved
src/utilities/index.ts Outdated Show resolved Hide resolved
src/utilities/index.ts Outdated Show resolved Hide resolved
@phryneas
Copy link
Member Author

phryneas commented Aug 1, 2023

Oh my god @jerelmiller, next time just tell me "dude, format that!", please don't put that much work in! 🤣
Thanks a ton!

Totally my fault - I had kinda anticipated that those would autoformat anyways after #11111, but thinking about it, that would only happen to those inside the react folder 😅

@phryneas phryneas merged commit 78739e3 into release-3.8 Aug 1, 2023
8 checks passed
@phryneas phryneas deleted the pr/type-exports branch August 1, 2023 08:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants