Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default memory limits #11495

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented Jan 17, 2024

Based on some internal testing, we've decided to increase the default memory limits for inMemoryCache.executeSelectionSet and inMemoryCache.executeSelectionSetArray.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: 67cebd1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the auto-cleanup 🤖 label Jan 17, 2024
Copy link
Contributor

github-actions bot commented Jan 17, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.22 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.02 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.57 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.96 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.88 KB (+0.02% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.2 KB (+0.02% 🔺)
import { useQuery } from "dist/react/index.js" (production) 4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.5 KB (+0.02% 🔺)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (+0.03% 🔺)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (+0.04% 🔺)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.27 KB (+0.02% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" (production) 3.93 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.74 KB (+0.03% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.39 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 4.96 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.62 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.03 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.97 KB (0%)
import { useFragment } from "dist/react/index.js" 2.18 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.13 KB (0%)

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit d1e6f02
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/65a80019da95d20008230825
😎 Deploy Preview https://deploy-preview-11495--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller jerelmiller merged commit 1190aa5 into release-3.9 Jan 17, 2024
18 of 23 checks passed
@jerelmiller jerelmiller deleted the jerel/increase-memory-limits branch January 17, 2024 16:35
@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit e6d87af
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/65a800ab5a84ea0008861288
😎 Deploy Preview https://deploy-preview-11495--apollo-client-docs.netlify.app/technotes
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Jan 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants