Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __typename and id properties to dataIdFromObject parameter #3641

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

jfurler
Copy link
Contributor

@jfurler jfurler commented Jul 2, 2018

This PR is the same as https://github.com/apollographql/apollo-client/pull/2274/files - that change seems to have got lost somewhere along the way.

@apollo-cla
Copy link

@jfurler: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@apollo-cla
Copy link

apollo-cla commented Jul 2, 2018

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - thanks for catching this @jfurler. LGTM!

@hwillson hwillson merged commit 0813c21 into apollographql:master Jul 17, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants