Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize to UNIX line ending #3693

Merged
merged 4 commits into from
Dec 12, 2018
Merged

Conversation

PowerKiKi
Copy link
Contributor

This is the de-facto standard for code and make contributing easier
for Linux users.

Not a single things was modified except the end of line character. If need be it can be reproduced with the following commands:

find . -type f -name '*.babelrc' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.flow' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.flowconfig' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.gitignore' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.iml' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.js' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.json' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.less' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.md' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.npmignore' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.prettierignore' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.sh' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.snap' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.svg' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.ts' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.xml' -exec sed -i''  $'s/\r$//' {} \;
find . -type f -name '*.yml' -exec sed -i''  $'s/\r$//' {} \;

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

This is the de-facto standard for code and make contributing easier
for Linux users.
@apollo-cla
Copy link

Warnings
⚠️

❗ Big PR

Generated by 🚫 dangerJS

@benjamn benjamn self-assigned this Sep 20, 2018
@hwillson hwillson self-assigned this Nov 14, 2018
@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #3693 into master will decrease coverage by 0.35%.
The diff coverage is 89.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
- Coverage   88.82%   88.46%   -0.36%     
==========================================
  Files          47       42       -5     
  Lines        2836     2202     -634     
  Branches      688      557     -131     
==========================================
- Hits         2519     1948     -571     
+ Misses        299      238      -61     
+ Partials       18       16       -2
Impacted Files Coverage Δ
packages/apollo-utilities/src/util/assign.ts 85.71% <ø> (-1.79%) ⬇️
packages/apollo-utilities/src/util/cloneDeep.ts 100% <ø> (ø) ⬆️
packages/apollo-utilities/src/directives.ts 84.31% <ø> (-1.66%) ⬇️
packages/apollo-utilities/src/fragments.ts 100% <ø> (ø) ⬆️
packages/apollo-client/scripts/tests.js 100% <100%> (ø)
packages/apollo-cache-inmemory/src/index.ts 100% <100%> (ø) ⬆️
packages/apollo-boost/src/index.ts 87.5% <87.5%> (-1.21%) ⬇️
packages/apollo-utilities/src/storeUtils.ts 29.7% <0%> (-8.56%) ⬇️
packages/apollo-utilities/src/getFromAST.ts 59.72% <0%> (-6.56%) ⬇️
packages/graphql-anywhere/src/utilities.ts 37.14% <0%> (-6.45%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb38d16...a99ebef. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #3693 into master will decrease coverage by 0.35%.
The diff coverage is 89.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
- Coverage   88.82%   88.46%   -0.36%     
==========================================
  Files          47       42       -5     
  Lines        2836     2202     -634     
  Branches      688      557     -131     
==========================================
- Hits         2519     1948     -571     
+ Misses        299      238      -61     
+ Partials       18       16       -2
Impacted Files Coverage Δ
packages/apollo-utilities/src/util/assign.ts 85.71% <ø> (-1.79%) ⬇️
packages/apollo-utilities/src/util/cloneDeep.ts 100% <ø> (ø) ⬆️
packages/apollo-utilities/src/directives.ts 84.31% <ø> (-1.66%) ⬇️
packages/apollo-utilities/src/fragments.ts 100% <ø> (ø) ⬆️
packages/apollo-client/scripts/tests.js 100% <100%> (ø)
packages/apollo-cache-inmemory/src/index.ts 100% <100%> (ø) ⬆️
packages/apollo-boost/src/index.ts 87.5% <87.5%> (-1.21%) ⬇️
packages/apollo-utilities/src/storeUtils.ts 29.7% <0%> (-8.56%) ⬇️
packages/apollo-utilities/src/getFromAST.ts 59.72% <0%> (-6.56%) ⬇️
packages/graphql-anywhere/src/utilities.ts 37.14% <0%> (-6.45%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb38d16...a99ebef. Read the comment docs.

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @PowerKiKi! We're going to handle this a bit differently, but thanks for kickstarting this process 👍.

@hwillson hwillson merged commit 1e89bb3 into apollographql:master Dec 12, 2018
@PowerKiKi PowerKiKi deleted the newlines branch December 27, 2021 09:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants