Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed fragment matcher error message #3701

Merged
merged 8 commits into from
Aug 9, 2018
Merged

Fixed fragment matcher error message #3701

merged 8 commits into from
Aug 9, 2018

Conversation

combizs
Copy link
Contributor

@combizs combizs commented Jul 17, 2018 •
edited by hwillson
Loading

Fix fragment matcher error message in console.warn(...)
Add to changelog

Fixes #3700.

@apollo-cla
Copy link

apollo-cla commented Jul 17, 2018 •
edited
Loading

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

@combizs combizs mentioned this pull request Jul 17, 2018
Closed
@combizs combizs changed the title Fixed fragment matcher error message, closes #3700 Fixed fragment matcher error message Jul 17, 2018
hwillson
hwillson approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @combizs!

@hwillson hwillson merged commit d3c8d00 into apollographql:master Aug 9, 2018
@dependencies dependencies bot mentioned this pull request Aug 17, 2018
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@combizs @apollo-cla @hwillson