Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ApolloClient#stop for safe client disposal. #4336

Merged
merged 5 commits into from
Jan 18, 2019
Merged

Support ApolloClient#stop for safe client disposal. #4336

merged 5 commits into from
Jan 18, 2019

Commits on Jan 18, 2019

  1. Support ApolloClient#stop for safe client disposal. 

    Inspired by apollographql/react-apollo#2738, it
should be possible to shut down an ApolloClient instance without making
assumptions about its implementation details.

This client.stop() method should also be useful for server-side rendering,
where you're supposed to create (and throw away) a new ApolloClient
instance for each request.

I'm not entirely sure this implementation cleans up everything that might
need to be cleaned up, but I am sure it's better than nothing.
    @benjamn
    benjamn committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    cae3a59 View commit details
    Browse the repository at this point in the history

  2. Increase apollo-client bundle size limit after adding stop methods.

    @benjamn
    benjamn committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    a064589 View commit details
    Browse the repository at this point in the history

  3. Exercise ApolloClient#stop and QueryManager#stop in tests.

    @benjamn
    benjamn committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    c5006bd View commit details
    Browse the repository at this point in the history

  4. Add ApolloClient#stop to the API docs.

    @benjamn
    benjamn committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    2396d36 View commit details
    Browse the repository at this point in the history

  5. Small tweaks to ApolloClient#stop documentation.

    @benjamn
    benjamn committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    edc2828 View commit details
    Browse the repository at this point in the history