Fully remove prettier #5227
Merged
Fully remove prettier #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes were made a while back to stop `prettier` changes from being applied automatically at commit time. This commit goes further and fully removes `prettier`. The Apollo Client team has decided to no longer use `prettier` to enforce code formatting across the codebase. In most cases existing code styles should be followed as much as possible, but this is not a hard and fast rule.
StephenBarlow
pushed a commit
that referenced
this pull request
Oct 1, 2019
Changes were made a while back to stop `prettier` changes from being applied automatically at commit time. This commit goes further and fully removes `prettier`. The Apollo Client team has decided to no longer use `prettier` to enforce code formatting across the codebase. In most cases existing code styles should be followed as much as possible, but this is not a hard and fast rule.
|
What was the motivation of this choice ? I'm just curious as it's more and more used across projects |
|
+1 @hwillson would love to know why this was made and if you recommend others do it too? |
|
There's a great explanation in this |
|
Thanks very interesting! On the review part of the issue, I discovered not so long ago this option on Github, that sadly on need to recheck every single time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were made a while back to stop
prettierchanges from being applied automatically at commit time. This commit goes further and fully removesprettier. The Apollo Client team has decided to no longer useprettierto enforce code formatting across the codebase. In most cases existing code styles should be followed as much as possible, but this is not a hard and fast rule.