Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficiently canonicalize InMemoryCache result objects. #7439

Merged
merged 12 commits into from
Dec 16, 2020
Merged

Efficiently canonicalize InMemoryCache result objects. #7439

merged 12 commits into from
Dec 16, 2020

Commits on Dec 15, 2020

  1. Efficiently canonicalize InMemoryCache result objects. 

    #4141 (comment)
    @benjamn
    benjamn committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    7ff1b31 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Pass scalar field values through without canonicalizing them.

    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    789f46b View commit details
    Browse the repository at this point in the history

  2. Test === equality for partial results from different queries.

    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    05c362f View commit details
    Browse the repository at this point in the history

  3. Bump bundlesize limit from 24.5kB to 24.9kB.

    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    3059ee3 View commit details
    Browse the repository at this point in the history

  4. Test that canonicalization does not modify scalar objects.

    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    8989ad3 View commit details
    Browse the repository at this point in the history

  5. Improve Canon class comments.

    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    cad1a06 View commit details
    Browse the repository at this point in the history

  6. Rename Canon class to ObjectCanon.

    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    9c6a09c View commit details
    Browse the repository at this point in the history

  7. Avoid wrapping non-object values with Pass wrappers.

    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e8f3ef8 View commit details
    Browse the repository at this point in the history

  8. Update optimism and import Trie from @wry/trie instead. 

    As suggested by @hwillson in this comment:
#7439 (comment)
    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    9fe2173 View commit details
    Browse the repository at this point in the history

  9. Use firstValueIndex variable to make array indexing clearer. 

    #7439 (comment)
    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    bdf3491 View commit details
    Browse the repository at this point in the history

  10. Add more direct unit tests of ObjectCanon. 

    #7439 (review)
    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    d6c5826 View commit details
    Browse the repository at this point in the history

  11. Mention PR #7439 in CHANGELOG.md.

    @benjamn
    benjamn committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    48bd0b1 View commit details
    Browse the repository at this point in the history