globalThis instead of global

[jean9696]

global is a node js const see more. We should use globalThis here.

[fbartho]

I was concerned about your initial window proposal, but I see you’ve swapped that out.

I’m unfamiliar with globalThis though I’ve seen it referenced in typings over the past couple years. Will look up what it’s for!

[jean9696]

It should allow managing all environments. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis

[fbartho]

@jean9696 I notice that it isn't supported on Internet Explorer -- do you know if ApolloClient still supports IE? or can we ignore that detail? (apollo-link-rest is supposed to match ApolloClient's support matrix)

[jean9696]

@fbartho indeed, but I don't think that apollo client supports internet explorer since it's using fetch which is not supported by default by IE according to caniuse (related issue: apollographql/apollo-link#357)

[fbartho]

@jean9696 Can you look at this commit to see if you approve of it? 26a799b

If yes, I'm happy to merge this so it ships in the next release.

[jean9696]

LGTM 👍

[fbartho]

Shipped in v0.9.0-rc.1

[fbartho]

Shipped this in v0.9.0! -- Enjoy! https://www.npmjs.com/package/apollo-link-rest/v/0.9.0