Make throttle underscored #296
Merged
+28
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should probably be public but underscored. |
FranzBusch
force-pushed
the
fb-throttle-internal
branch
from
1b7d4b0
to
7c50306
Compare
# Motivation During the discussion in apple#248 it became clear that the semantics of `throttle` are not 100% figured out yet. # Modification This PR is making `throttle` an underscored API for the upcoming 1.0.0 release. This gives us more time to investigate what exact semantics we want to have.
FranzBusch
force-pushed
the
fb-throttle-internal
branch
from
7c50306
to
3ab80c0
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
I'm not sure where the appropriate place to post this observation, but if we’ve changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the discussion in #248 it became clear that the semantics of
throttleare not 100% figured out yet.Modification
This PR is making
throttlean underscored API for the upcoming 1.0.0 release. This gives us more time to investigate what exact semantics we want to have.