Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: remove invalid file characters #34

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

compnerd
Copy link
Contributor

@compnerd compnerd commented May 5, 2021

: is not supported on Windows as a valid file name character. Replace
the : with -.

Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

`:` is not supported on Windows as a valid file name character.  Replace
the `:` with `-`.
@compnerd compnerd requested a review from lorentey as a code owner May 5, 2021 20:32
@compnerd
Copy link
Contributor Author

compnerd commented May 5, 2021

@swift-ci please test

Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lorentey
Copy link
Member

lorentey commented May 7, 2021

@swift-ci test

@compnerd
Copy link
Contributor Author

compnerd commented May 8, 2021

@lorentey - mind merging this change? It actually prevents even cloning the repository on Windows.

@lorentey lorentey merged commit b91621e into apple:main May 10, 2021
@lorentey lorentey linked an issue May 12, 2021 that may be closed by this pull request
2 tasks
@lorentey lorentey mentioned this pull request May 12, 2021
2 tasks
@lorentey lorentey added this to the 0.0.3 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Windows Paths
2 participants