Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more PCAP #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

more PCAP #158

wants to merge 1 commit into from

Conversation

weissi
Copy link
Member

@weissi weissi commented Apr 21, 2022

Motivation:

PCAP is an important protocol. Previously the implementation was very incomplete and split between NIOWritePCAPHandler and its tests.

Modifications:

  • Put the implementation into a (private) NIOPCAP module.

Result:

  • More PCAP capabilities.

@weissi weissi force-pushed the jw-more-pcap branch 2 times, most recently from ffa1262 to 6b265ef Compare April 21, 2022 16:22
@weissi weissi mentioned this pull request Nov 25, 2022
Merged
@weissi weissi marked this pull request as ready for review December 16, 2022 15:37
@weissi weissi requested a review from Lukasa December 16, 2022 15:37
@weissi weissi force-pushed the jw-more-pcap branch 5 times, most recently from b3c880c to 8b63363 Compare December 16, 2022 16:02
@weissi weissi added the semver/minor Adds new public API. label Dec 19, 2022
Lukasa
Lukasa approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly fine as an internal interface.

Sources/NIOPCAP/PCAP.swift Show resolved Hide resolved
Sources/NIOPCAP/PCAP.swift Outdated Show resolved Hide resolved
@weissi weissi enabled auto-merge (squash) March 22, 2023 12:54
@Lukasa
Copy link
Contributor

Lukasa commented Mar 22, 2023

Can you re-run the soundness script and commit the results please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weissi @Lukasa