Added HTTP encoder tests for 304 Not Modified responses

apple · Jun 10, 2024 · 9611cb9 · 9611cb9
1 parent 6602fd1
commit 9611cb9
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/Tests/NIOHTTP1Tests/HTTPResponseEncoderTest.swift b/Tests/NIOHTTP1Tests/HTTPResponseEncoderTest.swift
@@ -117,6 +117,12 @@ class HTTPResponseEncoderTests: XCTestCase {
         writtenData.assertContainsOnly("HTTP/1.1 204 No Content\r\ncontent-length: 0\r\n\r\n")
     }
 
+    func testNoContentLengthHeadersFor304() throws {
+        let headers = HTTPHeaders([("content-length", "0")])
+        let writtenData = sendResponse(withStatus: .notModified, andHeaders: headers)
+        writtenData.assertContainsOnly("HTTP/1.1 304 Not Modified\r\n\r\n")
+    }
+
     func testNoTransferEncodingHeadersFor101() throws {
         let headers = HTTPHeaders([("transfer-encoding", "chunked")])
         let writtenData = sendResponse(withStatus: .switchingProtocols, andHeaders: headers)
@@ -153,6 +159,12 @@ class HTTPResponseEncoderTests: XCTestCase {
         writtenData.assertContainsOnly("HTTP/1.1 204 No Content\r\ntransfer-encoding: chunked\r\n\r\n")
     }
 
+    func testNoTransferEncodingHeadersFor304() throws {
+        let headers = HTTPHeaders([("transfer-encoding", "chunked")])
+        let writtenData = sendResponse(withStatus: .notModified, andHeaders: headers)
+        writtenData.assertContainsOnly("HTTP/1.1 304 Not Modified\r\n\r\n")
+    }
+
     func testNoChunkedEncodingForHTTP10() throws {
         let channel = EmbeddedChannel()
         defer {