Implement remoteAddress0 and localAddress0 on EmbeddedChannel
#2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-embedded-addresses
branch
from
39d08db
to
af3bd73
Compare
Lukasa
requested changes
Jan 11, 2023
FranzBusch
force-pushed
the
fb-embedded-addresses
branch
from
af3bd73
to
9067e57
Compare
# Motivation `EmbeddedChannel` is often used in testing and currently any code under testing that uses `context.localAddress` cannot be mocked, since `EmbeddedChannelCore` is always throwing. # Modification Use the same values for `localAddress` in `localAddress0()`. Same for `remoteAddress` # Result We can now properly test code that needs local/remote addresses with `EmbeddedChannel`
FranzBusch
force-pushed
the
fb-embedded-addresses
branch
from
9067e57
to
faca55d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
EmbeddedChannelis often used in testing and currently any code under testing that usescontext.localAddresscannot be mocked, sinceEmbeddedChannelCoreis always throwing.Modification
Use the same values for
localAddressinlocalAddress0(). Same forremoteAddressResult
We can now properly test code that needs local/remote addresses with
EmbeddedChannel