Add support for UDP_GRO #2385
Merged
Add support for UDP_GRO #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Support was added for UDP_SEGMENT in apple#2372 which allows for large UDP datagrams to be written to a socket by letting the kernel or NIC segment the data across multiple datagrams. This reduces traversals across the network stack which can lead to performance improvements. UDP_GRO is the receive-side counterpart allowing the kernel/NIC to aggregate datagrams and reduce network stack traversals. Modifications: - Add a function in CNIOLinux to check whether UDP_GRO is supported - Add the relevant socket and channel options - Add tests Result: - UDP_GRO can be enabled where supported and applications may receive large buffers.
Lukasa
reviewed
Mar 6, 2023
|
|
||
| static func setUDPReceiveOffload(_ enabled: Bool, socket: NIOBSDSocket.Handle) throws { | ||
| #if os(Linux) | ||
| var isEnabled: CInt = enabled ? 1 : 0 |
There was a problem hiding this comment.
I think so: option_value in setsockopt takes an UnsafeRawPointer
Lukasa
approved these changes
Mar 6, 2023
|
These tests are failing for me on Ubuntu 20.04 x86_64 and the CI is not running them, which may be why that was missed: This is the error I see when they are run locally: |
|
Thanks for this. We’re tracking this on our side as well, as our internal CI platform has also flagged this regression. |
|
Also as a breadcrumb, can you provide the output of |
|
|
10/10 for the hostname. |
|
We also see failures on 5.4. FWIW these tests do pass with a newer kernel (5.15). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Support was added for UDP_SEGMENT in #2372 which allows for large UDP datagrams to be written to a socket by letting the kernel or NIC segment the data across multiple datagrams. This reduces traversals across the network stack which can lead to performance improvements. UDP_GRO is the receive-side counterpart allowing the kernel/NIC to aggregate datagrams and reduce network stack traversals.
Modifications:
Result: