Add unprocessedBytes property on NIOSingleStepByteToMessageProcessor #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
commented
May 3, 2023
Comment on lines
-33
to
-44
| private final class ForeverDecoder: NIOSingleStepByteToMessageDecoder { | ||
| typealias InboundOut = Never | ||
|
|
||
| func decode(buffer: inout ByteBuffer) throws -> InboundOut? { | ||
| return nil | ||
| } | ||
|
|
||
| func decodeLast(buffer: inout ByteBuffer, seenEOF: Bool) throws -> InboundOut? { | ||
| XCTAssertTrue(seenEOF) | ||
| return try self.decode(buffer: &buffer) | ||
| } | ||
| } |
There was a problem hiding this comment.
totally unused. This is why I removed it.
Lukasa
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unprocessedBytes property on NIOSingleStepByteToMessageProcessor
Motivation:
Some protocols require no messages to be in the incoming buffer after a certain message was received. For example if both endpoints agree on an upgrade to TLS no remaining bytes should be in the incoming buffer (as those would have been sent unencrypted or those may have been injected by a man in the middle). We should allow to ask the
NIOSingleStepByteToMessageProcessorif there are bytes remaining in its incoming buffer.Modifications:
Result: