Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating a yield ID counter per async writer #2768

Merged
merged 4 commits into from
Jul 9, 2024

Commits on Jul 5, 2024

  1. Avoid creating a yield ID counter per async writer

    Motivation:
    
    The NIOAsyncWriter uses an atomic to generate yield IDs. Each writer has
    its own atomic. We can save an allocatiuon per writer but using a shared
    atomic.
    
    Each load then wrapping increment operation with relaxed ordering takes
    approx 3ns on my machine. For a UInt64 this would take approx 188 years
    to wrap around if run in a tight loop.
    
    Modification:
    
    - Share a single yield ID counter for NIOAsyncWriter
    
    Result:
    
    Fewer allocations
    glbrntt committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    921a1ad View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. better naming

    glbrntt committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    95f909a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0026472 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    2d77b0c View commit details
    Browse the repository at this point in the history