explain why typealias is complicated #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
We should explain why this typealias
public typealias RangeType<Bound> = CountableRange<Bound> where Bound: Strideable, Bound.Stride: SignedInteger
isn't just
public typealias RangeType = CountableRange
and that's because SR-6963.
Modifications:
added a comment explaining why
Result:
code easier to read
Lukasa
approved these changes
May 21, 2018
There was a problem hiding this comment.
Good call. No need for @normanmaurer to come back from his day off early to review this, I'll merge directly.
|
👍 Sent with GitHawk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @BasThomas , forgot to address your comment before merge.
Motivation:
We should explain why this typealias
isn't just
and that's because SR-6963.
Modifications:
added a comment explaining why
Result:
code easier to read