Don't provide promises when we don't care about results. #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When we don't care about the result of an operation, we shouldn't provide a promise. While I'm here I also removed an unnecessary close() call in the AcceptHandler: the close() would be called again almost immediately. Modifications: Removed a close() call. Set `promise: nil` on a pair of close() calls. Result: Fewer promise allocations.
normanmaurer
approved these changes
May 24, 2018
|
@Lukasa just as a question: This should allocate fewer promises, right? Did you check the allocation limits? Sorry should've asked that earlier but maybe we can do that post 1.7.2 |
|
I think this promise removal was only on error paths, so it shouldn’t have affected our tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When we don't care about the result of an operation, we shouldn't provide
a promise.
While I'm here I also removed an unnecessary close() call in the
AcceptHandler: the close() would be called again almost immediately.
Modifications:
Removed a close() call.
Set
promise: nilon a pair of close() calls.Result:
Fewer promise allocations.