Conform Quaternion to Elementary Functions #230
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3262d4d.
Adds quaternionic inverse cosine, inverse sine and inverse tangent. Specialized inverse hyperbolic cosine and inverse hyperbolic sine based on these functions.
|
The implementation is still functional, but I am trying to improve the error bounds on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #206 and adds the remaining quaternionic elementary functions; making
Quaternionfully conform toElementaryFunctions. 🎉Most of the functions draw inspiration from the implementation details of the corresponding elementary function on complex numbers. Nonetheless, I greatly appreciate every comment, feedback or suggestions!
Links to new elementary functions: