-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compat suite OpenAPI documents to their latest versions #418
Conversation
@swift-server-bot compat-test-full |
Looks like even the non-build compat test failed. 🥴 |
Yup, I didn't actually run GitHub and GitHub Enterprise locally, I'll make the necessary fixes. Seems it's just the expected diagnostics changed. |
@swift-server-bot compat-test-full |
Ok I also ran and built both GitHub's locally (they're disabled in CI). All good. |
@simonjbeaumont the build timed out after 60min 😕 |
Yep. It will do that. We could potentially filter GitHub before building and/or increase the timeout, given this job doesn't run on every PR. We can also consider some suggestions in #253. |
I don't think we build either GitHub in the full pipeline, so it's strange that it still timed out. Should I disable another large doc from building to get it through? |
Potentially we regressed our generation and/or compile times since we introduced this pipeline. Be curious to understand by how much, the numbers posted by the adopter on the other issue seem to suggest quite a bit. |
Didn't we also last test this on 5.8, and switched to 5.9 since? |
Yeah, last time this passed was in early October still on 5.8: https://ci.swiftserver.group/job/swift-openapi-generator-compatibility-test-full-prb/12/ |
Probably worth getting this to run periodically. So there's a few variables here:
|
Yup I think all of our PR pipelines should also run nightly, as a baseline. |
Motivation
Update the docs used by the compat suite, to be representative for 1.0.
Modifications
Updated to the latest versions of all docs.
Result
Using the latest versions.
Test Plan
CI passed (both generation and building), and locally I ran both GitHubs, as they don't build in CI even in the full pipeline.