Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat suite OpenAPI documents to their latest versions #418

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

czechboy0
Copy link
Collaborator

@czechboy0 czechboy0 commented Dec 3, 2023

Motivation

Update the docs used by the compat suite, to be representative for 1.0.

Modifications

Updated to the latest versions of all docs.

Result

Using the latest versions.

Test Plan

CI passed (both generation and building), and locally I ran both GitHubs, as they don't build in CI even in the full pipeline.

@czechboy0
Copy link
Collaborator Author

@swift-server-bot compat-test-full

@simonjbeaumont
Copy link
Collaborator

Looks like even the non-build compat test failed. 🥴

@czechboy0
Copy link
Collaborator Author

Looks like even the non-build compat test failed. 🥴

Yup, I didn't actually run GitHub and GitHub Enterprise locally, I'll make the necessary fixes. Seems it's just the expected diagnostics changed.

@czechboy0
Copy link
Collaborator Author

@swift-server-bot compat-test-full

@czechboy0
Copy link
Collaborator Author

Ok I also ran and built both GitHub's locally (they're disabled in CI). All good.

@czechboy0 czechboy0 marked this pull request as ready for review December 3, 2023 16:59
@czechboy0 czechboy0 changed the title [WIP] Update compat suite OpenAPI documents to their latest versions Update compat suite OpenAPI documents to their latest versions Dec 3, 2023
@czechboy0
Copy link
Collaborator Author

@simonjbeaumont the build timed out after 60min 😕

@simonjbeaumont
Copy link
Collaborator

@simonjbeaumont the build timed out after 60min 😕

Yep. It will do that. We could potentially filter GitHub before building and/or increase the timeout, given this job doesn't run on every PR.

We can also consider some suggestions in #253.

@czechboy0
Copy link
Collaborator Author

We could potentially filter GitHub before building and/or increase the timeout, given this job doesn't run on every PR.

I don't think we build either GitHub in the full pipeline, so it's strange that it still timed out. Should I disable another large doc from building to get it through?

@simonjbeaumont
Copy link
Collaborator

Potentially we regressed our generation and/or compile times since we introduced this pipeline. Be curious to understand by how much, the numbers posted by the adopter on the other issue seem to suggest quite a bit.

@czechboy0
Copy link
Collaborator Author

Didn't we also last test this on 5.8, and switched to 5.9 since?

@czechboy0
Copy link
Collaborator Author

Yeah, last time this passed was in early October still on 5.8: https://ci.swiftserver.group/job/swift-openapi-generator-compatibility-test-full-prb/12/

@simonjbeaumont
Copy link
Collaborator

Probably worth getting this to run periodically.

So there's a few variables here:

  • the generator version
  • the document versions
  • the toolchain version

@czechboy0
Copy link
Collaborator Author

Yup I think all of our PR pipelines should also run nightly, as a baseline.

@czechboy0 czechboy0 marked this pull request as draft December 8, 2023 14:18
@czechboy0 czechboy0 marked this pull request as ready for review December 13, 2023 16:29
@czechboy0 czechboy0 enabled auto-merge (squash) December 13, 2023 16:29
@czechboy0 czechboy0 merged commit c0402fe into apple:main Dec 13, 2023
9 checks passed
@czechboy0 czechboy0 deleted the hd-bump-compat-suite branch December 13, 2023 16:47
@czechboy0 czechboy0 added the semver/none No version bump required. label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants