Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/documentation #1359

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Improve/documentation #1359

wants to merge 7 commits into from

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Oct 4, 2024

Description of the Change

Document all APIs with swagger

In order to replace / automate the API documentation on https://www.aptly.info/doc/api document API calls with swagger.

About 40 APIs currently only have stubs and need to be documented:

git grep "@Summary TODO"

Run swagger

make docker-dev-server

See Swagger doc: http://localhost:3142/docs

Note: as the dev server has live reload, changes to the code will be recompiled, then the page can be reloaded.

Examples

image

image

Document aptly.conf

Found that aptly uses github.com/DisposaBoy/JsonConfigReader already, tunrs our it supports comments in json,
so we can have a inline documented config file.

Checklist

  • man page updated (if applicable)
  • swagger documentation updated
  • pipeline to publish CI or Release doc somewhere (gh-pages / aptly.info?)

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (d6a156b) to head (5156aa0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1359   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files         151      151           
  Lines       17121    17121           
=======================================
  Hits        12808    12808           
  Misses       3290     3290           
  Partials     1023     1023           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx self-assigned this Oct 4, 2024
@neolynx neolynx requested a review from a team October 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant