Parse dependency architecture even without version

[rmedaer]

This commit closes: #145

Description of the Change

The dependency format "pkg:arch" (e.g. "python3:any") was not well parsed if not any version is given. This commit splits the dependency name and architecture in all cases.

Checklist

• unit-test added (if change is algorithm)
• functional test added/updated (if change is functional)
• man page updated (if applicable)
• bash completion updated (if applicable)
• documentation updated
• author name in AUTHORS

[codecov]

Codecov Report

Merging #868 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   63.79%   63.81%   +0.01%     
==========================================
  Files          54       54              
  Lines        6662     6665       +3     
==========================================
+ Hits         4250     4253       +3     
  Misses       1887     1887              
  Partials      525      525

Impacted Files	Coverage Δ
deb/version.go	92.35% <100%> (+0.14%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae5a12...a05cc3a. Read the comment docs.

[smira]

thanks, the change looks good to me, but could you please add a unit-test to deb/version_test.go to make sure python:any (and other similar) are now properly parsed?

[rmedaer]

I added a test in DependencyString. Here is the result without my PR:

FAIL: version_test.go:227: VersionSuite.TestDependencyString

version_test.go:237:
    c.Check(d.Pkg, Equals, "dpkg")
... obtained string = "dpkg:any"
... expected string = "dpkg"

OOPS: 159 passed, 1 FAILED
--- FAIL: Test (5.36s)
FAIL
exit status 1
FAIL	github.com/aptly-dev/aptly/deb	5.369s

and with my PR:

OK: 160 passed
PASS
ok  	github.com/aptly-dev/aptly/deb	5.266s

[smira]

@rmedaer thanks, would you mind rebasing your PR and resolving conflicts so that it can be merged?

[rmedaer]

@smira it should be OK right now !

[smira]

thanks!