-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(checks): improve S3 server logging access detection for AVD-AWS-…
…0089 Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
- Loading branch information
Showing
4 changed files
with
182 additions
and
100 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,71 @@ | ||
| package builtin.aws.s3.aws0089 | ||
|
|
||
| test_detects_when_disabled { | ||
| test_deny_logging_disabled { | ||
| r := deny with input as {"aws": {"s3": {"buckets": [{"logging": {"enabled": {"value": false}}}]}}} | ||
| count(r) == 1 | ||
| } | ||
|
|
||
| test_when_enabled { | ||
| test_allow_logging_enabled { | ||
| r := deny with input as {"aws": {"s3": {"buckets": [{"logging": {"enabled": {"value": true}}}]}}} | ||
| count(r) == 0 | ||
| } | ||
|
|
||
| test_detects_when_disabled_but_acl_is_log_write { | ||
| test_allow_logging_disabled_but_bucket_has_server_logging_access_acl { | ||
| r := deny with input as {"aws": {"s3": {"buckets": [{ | ||
| "logging": {"enabled": {"value": false}}, | ||
| "acl": {"value": "log-delivery-write"}, | ||
| }]}}} | ||
| count(r) == 0 | ||
| } | ||
|
|
||
| test_detects_when_enabled_and_acl_is_not_log_write { | ||
| test_deny_logging_disabled_and_bucket_does_not_have_server_access_logging { | ||
| r := deny with input as {"aws": {"s3": {"buckets": [{ | ||
| "logging": {"enabled": {"value": false}}, | ||
| "acl": {"value": "private"}, | ||
| }]}}} | ||
| count(r) == 1 | ||
| } | ||
|
|
||
| test_allow_logging_disabled_but_bucket_has_server_logging_access_grant { | ||
| r := deny with input as {"aws": {"s3": {"buckets": [{ | ||
| "logging": {"enabled": {"value": false}}, | ||
| "acl": {"value": "log-delivery-write"}, | ||
| "grants": [ | ||
| { | ||
| "grantee": { | ||
| "id": {"value": "111122223333"}, | ||
| "type": {"value": "CanonicalUser"}, | ||
| }, | ||
| "permissions": [{"value": "FULL_CONTROL"}], | ||
| }, | ||
| { | ||
| "grantee": { | ||
| "uri": {"value": "http://acs.amazonaws.com/groups/s3/LogDelivery"}, | ||
| "type": {"value": "GROUP"}, | ||
| }, | ||
| "permissions": [ | ||
| {"value": "READ_ACP"}, | ||
| {"value": "WRITE"}, | ||
| ], | ||
| }, | ||
| ], | ||
| }]}}} | ||
| count(r) == 0 | ||
| } | ||
|
|
||
| test_allow_logging_disabled_but_bucket_has_server_logging_access_policy { | ||
| r := deny with input as {"aws": {"s3": {"buckets": [{ | ||
| "logging": {"enabled": {"value": false}}, | ||
| "bucketpolicies": [{"document": {"value": json.marshal({ | ||
| "Version": "2012-10-17", | ||
| "Statement": [{ | ||
| "Sid": "S3ServerAccessLogsPolicy", | ||
| "Effect": "Allow", | ||
| "Principal": {"Service": ["logging.s3.amazonaws.com"]}, | ||
| "Action": ["s3:PutObject"], | ||
| "Resource": "arn:aws:s3:::DOC-EXAMPLE-DESTINATION-BUCKET-logs/*", | ||
| }], | ||
| })}}], | ||
| }]}}} | ||
| count(r) == 0 | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.