Upgrade to ordered-float v2 #27
Conversation
There was a problem hiding this comment.
Sounds good to me. The tests also need some fixing for 2018 though: https://travis-ci.org/github/arcnmx/serde-value/builds/707870476 (not sure why github isn't showing this...)
|
Ah indeed, thanks. Pushed up a fix for the texts. |
|
And CI is happy, as far as I can tell: https://travis-ci.org/github/arcnmx/serde-value/builds/708024993 |
Cargo.toml
Outdated
|
|
||
| [dev-dependencies] | ||
| serde_derive = "^1.0.0" | ||
| serde = { version = "^1.0.0", features = ["derive"] } |
There was a problem hiding this comment.
So I don't think that actually does what it looks like it should - the "derive" feature now becomes a dependency of the normal library as well. Until this is fixed in cargo, keeping the separate serde_derive dependency is best.
There was a problem hiding this comment.
Oy, that's a major footgun. Thanks for catching. Figured out how to make this work while still using serde_derive.
Since ordered-float v2 bumps the MSRV to 1.34, might as well take the opportunity to upgrade to Rust 2018 syntax.
Two commits in here.
Upgrade to ordered-float v2.
The new version is semver incompatible with v1; upgrading here reduces the chance of duplicate copies of ordered-float in large dependency graphs.
Upgrade to Rust 2018.
Since ordered-float v2 bumps the MSRV to 1.34, might as well take the
opportunity to upgrade to Rust 2018 syntax.