ruby: use pkg-config to link SDL2 #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of assuming pkg-config is available with bash, test for its presence. This allows the build to function if using bash without pkg-config or using cmd with pkg-config. Instead of assuming the sdl2-config is available if pkg-config indicates that SDL2 is present, just use pkg-config directly to acquire the compile and link arguments. Again, this allows the build to work with cmd (since sdl2-config is a bash script) and if your copy of SDL2 just didn't come with sdl2-config (for example, from vcpkg).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assuming pkg-config is available with bash, test for its presence. This allows the build to function if using bash without pkg-config or using cmd with pkg-config.
Instead of assuming the sdl2-config is available if pkg-config indicates that SDL2 is present, just use pkg-config directly to acquire the compile and link arguments. Again, this allows the build to work with cmd (since sdl2-config is a bash script) and if your copy of SDL2 just didn't come with sdl2-config (for example, from vcpkg).