BarcodeHandler.from_file: Pass down parameters
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `BarcodeHandler.__init__` has (optional) parameters to adjust barcode-related options (*e.g.* using non-`CB` SAM tags for the cell barcodes, like `XC`), the static `from_file` function called it without any of those parameters, making it impossible to adjust them when using that function. This is resolved by adding an optional keyword argument dictionary parameters to the static function and passing all argument provided therein, if any, down to the `__init__` call. This addresses one out of two issues raised in arogozhnikov#23.
This was referenced Feb 23, 2024
Closed
|
LGTM. I'd merge this, but github says I don't have write access (will figure this out soon) |
|
@arogozhnikov: I guess this has something to do with the organisation settings of @herophilus. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
BarcodeHandler.__init__has (optional) parameters to adjust barcode-related options (e.g. using non-CBSAM tags for the cell barcodes, likeXC), the staticfrom_filefunction called it without any of those parameters, making it impossible to adjust them when using that function.This is resolved by adding an optional keyword argument dictionary parameters to the static function and passing all argument provided therein, if any, down to the
__init__call.This addresses one out of two issues raised in #23.
closes #26