Remove quickcheck dev-dependency #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopopolo
added
C-quality
lopopolo
force-pushed
the
purge-quickcheck
branch
from
bc18902
to
0ec7626
Compare
Remove `quickcheck` dependency for `recover`, `temper`, and `untemper` tests. Replace with loops and `getrandom::getrandom` for generating integers to test. This removes all dependencies that pull in `rand` and `rand_core`, which will make updating `rand` in this crate easier moving forward.
lopopolo
force-pushed
the
purge-quickcheck
branch
from
0ec7626
to
0751380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
quickcheckdependency forrecover,temper, anduntempertests. Replace with loops and
getrandom::getrandomfor generatingintegers to test.
This removes all dependencies that pull in
randandrand_core, whichwill make updating
randin this crate easier moving forward.See BurntSushi/quickcheck#264 (comment).