Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix createMapper with inherit as plain object #93

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Fix createMapper with inherit as plain object #93

merged 1 commit into from
Dec 13, 2017

Conversation

sudo-suhas
Copy link
Collaborator

When inherit is a plain-object, the call to createDefaultMapper is incorrect. So this removes unnecessary destructured-object param to fix issue.

@asfktz
Copy link
Owner

asfktz commented Dec 13, 2017

Oh, good catch!

@asfktz asfktz merged commit 611b6f2 into master Dec 13, 2017
@asfktz
Copy link
Owner

asfktz commented Dec 13, 2017

Released a new version 🎉

@sudo-suhas sudo-suhas deleted the fix-createMapper branch December 14, 2017 00:20
@sudo-suhas
Copy link
Collaborator Author

sudo-suhas commented Dec 14, 2017 •
edited
Loading

😁👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudo-suhas @asfktz