Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple 'requests and topics' from RocketChat core - based on new UI #19

Closed
mrsimpson opened this issue Sep 22, 2017 · 3 comments
Closed

Decouple 'requests and topics' from RocketChat core - based on new UI #19

mrsimpson opened this issue Sep 22, 2017 · 3 comments
Assignees
@mrsimpson
Labels
Cmp: Threads Type: New Feature
Milestone
own-mid-term

Comments

@mrsimpson
Copy link
Member

mrsimpson commented Sep 22, 2017 •
edited
Loading

Context

Currently, all development of the assistify-extension of Rocket.Chat is implemented as a modification.
Though it's separated into packages, there are parts which are implemented as a modification. This is particularly valid for the requests and topics.

Aim

This issue is about separating all development into a meteor package which is published to meteor package registry: https://atmospherejs.com/

Current implementation

The package for the requests and topics is https://github.com/assistify/Rocket.Chat/tree/master/packages/assistify-help-request
There are no real dependencies to other custom packages, but actually all modifications applied to Rocket.Chat are necessary due to the features implemented in this package.

Process

In order to do that

  • contribute modifications to RC which enable APIs => Custom room types RocketChat/Rocket.Chat#8246
  • Merge the contributions-branch (regularly) to feature/#19-decouple-help-requests overwriting what's on the target branch
  • Get things working again (of course, we'll do unit-tests later ;) )
  • Once finished, extract the folder to a separate repo and publish it to meteorpedia
  • Delete the folder in this repo
@mrsimpson mrsimpson added this to the own-mid-term milestone Sep 25, 2017
@ruKurz ruKurz changed the title Decouple from RocketChat core - Requests and topics Decouple 'requests and topics' from RocketChat core Sep 25, 2017
@ghost ghost assigned mrsimpson Sep 26, 2017
@ghost ghost added the progress:working label Sep 26, 2017
mrsimpson added a commit that referenced this issue Sep 30, 2017
@mrsimpson
Merge branch 'core/RocketChat#8264-room-types' into feature/#19-decou…
aee8eac 
…ple-help-requests

# Conflicts:
#	.meteor/packages
#	.meteor/versions
#	packages/rocketchat-channel-settings/client/views/channelSettings.js
#	packages/rocketchat-channel-settings/server/functions/saveRoomName.js
#	packages/rocketchat-i18n/i18n/de.i18n.json
#	packages/rocketchat-ui-admin/client/rooms/adminRooms.js
#	packages/rocketchat-ui-flextab/client/tabs/membersList.js
#	packages/rocketchat-ui-message/client/messageBox.js
#	server/methods/eraseRoom.js
#	server/publications/spotlight.js
mrsimpson added a commit that referenced this issue Sep 30, 2017
@mrsimpson
Merge branch 'core/RocketChat#8264-room-types' into feature/#19-decou…
b285961 
…ple-help-requests
mrsimpson added a commit that referenced this issue Oct 1, 2017
@mrsimpson
Merge branch 'core/RocketChat#8264-room-types' into feature/#19-decou…
6bda889 
…ple-help-requests
mrsimpson added a commit that referenced this issue Oct 1, 2017
@mrsimpson
Merge branch 'core/RocketChat#8264-room-types' into feature/#19-decou…
ccaf349 
…ple-help-requests
@mrsimpson
Copy link
Member Author

Decoupling mostly done. PR towards RC: RocketChat#8274
The new creation page is - as expected - the major workaround with respect to our enhancement.

@mrsimpson mrsimpson mentioned this issue Oct 1, 2017
Closed
mrsimpson added a commit that referenced this issue Oct 2, 2017
@mrsimpson
Merge branch 'core/RocketChat#8264-room-types' into feature/#19-decou…
a87b575 
…ple-help-requests

# Conflicts:
#	packages/rocketchat-livechat/app/i18n/de.i18n.json
@mrsimpson
Copy link
Member Author

For documentation purposes and how (svg-) icons are handled in RC, see 8a1eb37

@mrsimpson mrsimpson changed the title Decouple 'requests and topics' from RocketChat core Decouple 'requests and topics' from RocketChat core - based on new UI Oct 4, 2017
mrsimpson added a commit that referenced this issue Oct 6, 2017
@mrsimpson
Merge branch 'core/RocketChat#8264-room-types-creation-ui' into feature/
3e8e8d0 
#19-decouple-help-requests
mrsimpson added a commit that referenced this issue Oct 6, 2017
@mrsimpson
Merge branch 'core/RocketChat#8264-room-types-creation-ui' into feature/
d077191 
#19-decouple-help-requests
@mrsimpson mrsimpson mentioned this issue Oct 9, 2017
Closed
mrsimpson added a commit that referenced this issue Oct 16, 2017
@mrsimpson
Merge branch 'feature/#19-decouple-help-requests' of https://github.c…
691934d 
…om/assistify/Rocket.Chat into feature/#19-decouple-help-requests

# Conflicts:
#	packages/assistify-help-request/client/views/sideNav/AssistifyCreateExpertise.js
mrsimpson added a commit that referenced this issue Oct 18, 2017
@mrsimpson
Merge branch 'feature/#19-decouple-help-requests' into release/0.59.0…
ac47559 
…_rc15-0.4.0
@mrsimpson
Copy link
Member Author

Completed with 3df84aa

@ghost ghost removed the progress:working label Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrsimpson mrsimpson

Labels
Cmp: Threads Type: New Feature
Projects
None yet
Milestone
own-mid-term
Development

No branches or pull requests
2 participants
@ruKurz @mrsimpson