Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to v1.78 #3361

Merged
merged 3 commits into from
May 3, 2024
Merged

Conversation

samypr100
Copy link
Contributor

@samypr100 samypr100 commented May 3, 2024

Summary

Updates rust to 1.78 in rust-toolchain.toml

See: https://blog.rust-lang.org/2024/05/02/Rust-1.78.0.html

Potential blockers

@charliermarsh
Copy link
Member

I think it's ok for us to upgrade rust-toolchain.toml but not the minimum Rust version in Cargo.toml (see astral-sh/ruff#11260).

@charliermarsh
Copy link
Member

Which would let us upgrade without having to wait for Homebrew and Conda, IIRC.

Copy link

codspeed-hq bot commented May 3, 2024

CodSpeed Performance Report

Merging #3361 will improve performances by 5.78%

Comparing samypr100:rust-update-178 (5030cea) with main (1089abd)

Summary

⚡ 1 improvements
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark main samypr100:rust-update-178 Change
resolve_warm_jupyter 376.3 ms 355.7 ms +5.78%

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label May 3, 2024
@samypr100 samypr100 marked this pull request as ready for review May 3, 2024 19:55
@charliermarsh charliermarsh enabled auto-merge (squash) May 3, 2024 19:58
@charliermarsh charliermarsh merged commit 2ffb252 into astral-sh:main May 3, 2024
43 checks passed
@samypr100 samypr100 deleted the rust-update-178 branch May 3, 2024 20:08
konstin added a commit that referenced this pull request May 6, 2024
Followup to #3361, fix some backtick-quoting.
konstin added a commit that referenced this pull request May 6, 2024
Followup to #3361, fix some backtick-quoting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants