Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error[E0008]: cannot bind by-move into a pattern guard #231

Closed
wants to merge 1 commit into from

Conversation

froody
Copy link

@froody froody commented Sep 22, 2019

Fixes the following error:

Error: error[E0008]: cannot bind by-move into a pattern guard
--> src/net/driver/mod.rs:207:17
|
207 | Err(err) if err.kind() == io::ErrorKind::WouldBlock => {}
| ^^^ moves value into pattern guard
|
= help: add #![feature(bind_by_move_pattern_guards)] to the crate attributes to enable

@taiki-e
Copy link
Contributor

taiki-e commented Sep 22, 2019

As bind_by_move_pattern_guards stabilized about two weeks ago (rust-lang/rust#63118), I believe updating the version of rustc should fix this error.

@ghost
Copy link

ghost commented Sep 22, 2019

@froody what is your rustc version?

@froody
Copy link
Author

froody commented Sep 23, 2019

@stjepang 1.38, updating to 1.39 isn't really feasible right now

@yoshuawuyts
Copy link
Contributor

We haven't quite talked about this internally, but given nobody on the team has really moved to act on this PR I think there's a silent consensus that we're not targeting any versions of the compiler under 1.39.

We probably should still formulate our support strategy in the face of the upcoming stabilization of async/await. I suspect it'll be something like: "always work on stable; only conditionally support new nightly features".

Either way, I don't want to keep this PR open indefinitely so I'm going to go ahead and close this. Thanks heaps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants