Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix "Installing modules failed" on Atom #645

Merged
merged 1 commit into from
Nov 13, 2016
Merged

Fix "Installing modules failed" on Atom #645

merged 1 commit into from
Nov 13, 2016

Conversation

jsolisu
Copy link
Contributor

@jsolisu jsolisu commented Nov 12, 2016

I have winreg on package.json (Atom) linked to github:jsolisu/node-winreg, when i use: script\build or script\bootstrap APM fails with "Installing modoles failed..."

The problem is because PATH is undefined. I revert changes from 1.15.0 using 1.14.1 version of command.coffee

npm-debug.log.txt

@50Wliu
Copy link
Contributor

50Wliu commented Nov 13, 2016

/cc @damieng

@damieng
Copy link
Contributor

damieng commented Nov 13, 2016

I'm curious as to why this is breaking on your system.

Environment variables are case-insensitive in node since v4 nodejs/node#9157

@jsolisu
Copy link
Contributor Author

jsolisu commented Nov 13, 2016

@damieng It is right. Please note the effect on the image. It´s similar to: atom/atom#11302

error

@damieng damieng merged commit 4d8ffb6 into atom:master Nov 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants