Add pagination support for search and add stats endpoint support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds support for getting download count
|
Hey @atotto we find this PR quite useful as it will allow us to stop using the packagecloud gem. Is there something we could do to help get it merged. |
alephnull
added a commit
to TykTechnologies/golang-cross
that referenced
this pull request
Dec 14, 2023
Removed unused ppc64le arch Removed ruby dependency package_cloud If atotto/packagecloud#5 gets merged, then we should change the location in pc.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to use this as a base for some automation around packagecloud, and realized that the search endpoint only returned the first page of results.
This PR adds the support for traversing the web link based pagination supported by packagecloud.
Have also added a few stats endpoints that fetches the package specific download details.