Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add positive grading to assessments #1618

Merged
merged 20 commits into from
Oct 4, 2022
Merged

Conversation

victorhuangwq
Copy link
Contributor

@victorhuangwq victorhuangwq commented Sep 29, 2022

Description

Adds ability to do positive grading to assignments as well as the following sub-features:

  • Warning when switching between positive and negative if there's currently an annotation
  • Add an indication about whether it's positive or negative grading in the annotation box
  • Add is_positive_grading to export assessments

Motivation and Context

Iliano requested the feature to be added as changing 122 rubrics from positive to negative has been difficult for their class.

How Has This Been Tested?

Grading style testing

Tested negative grading:
image
image

Tested positive grading:
image
image

Tested Annotations Warning

  • Tested changing when there are annotations > warning shows
  • Tested changing when there are no annotations > warning does not show

Tested Import & Export

  • Turned on positive grading
  • Export assessment and check yml image
  • Imported and checked that positive grading is one

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@victorhuangwq victorhuangwq changed the title [Draft] Add positive grading [WIP] Add positive grading Sep 29, 2022
@victorhuangwq victorhuangwq marked this pull request as draft September 29, 2022 21:10
@victorhuangwq victorhuangwq marked this pull request as ready for review September 29, 2022 21:35
@victorhuangwq victorhuangwq changed the title [WIP] Add positive grading Add positive grading to assessments Sep 29, 2022
@victorhuangwq
Copy link
Contributor Author

victorhuangwq commented Sep 29, 2022

  • Add warning when switching between positive and negative if there's annotation
  • Add an indication about whether it's positive or negative grading

@victorhuangwq
Copy link
Contributor Author

victorhuangwq commented Oct 2, 2022

  • Add is_positive_grading to export assessments

Copy link
Member

@damianhxy damianhxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, works as expected

Left some comments, but otherwise lgtm!

app/assets/javascripts/edit_assessment.js Outdated Show resolved Hide resolved
app/assets/stylesheets/style.css.scss Outdated Show resolved Hide resolved
app/form_builders/form_builder_with_date_time_input.rb Outdated Show resolved Hide resolved
app/views/assessments/_edit_problems.html.erb Outdated Show resolved Hide resolved
app/views/assessments/_edit_problems.html.erb Show resolved Hide resolved
@damianhxy
Copy link
Member

LGTM!

@victorhuangwq victorhuangwq merged commit 524d4bb into master Oct 4, 2022
@victorhuangwq victorhuangwq deleted the add_positive_grading branch October 4, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants