Skip to content

Commit

Permalink
fix(elasticloadbalancingv2-targets): add AlbListenerTarget for NLBs, …
Browse files Browse the repository at this point in the history
…deprecate AlbTarget due to ALB listener race conditions (#17208) (#30396)

### Issue # (if applicable)
Closes #17208 .

### Description of changes

- This PR replaces `AlbTarget` with `AlbListenerTarget`, allowing us to automatically add a dependency between the provided ALB listener and the associated NLB target group. Without such a dependency stacks may fail to deploy if the listener is not created when the target group attempts to be created.
- Also, As described - #17208 (comment) , it will handle graceful deletion of resources.
### Description of how you validated changes
- Added UnitTests
- Ran integrationTests as below,
```
$ yarn integ aws-elasticloadbalancingv2-targets/test/integ.alb-listner-target.js --update-on-failed
```

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
stm29 authored Aug 15, 2024
1 parent 277d5b9 commit 1fca1e5
Show file tree
Hide file tree
Showing 13 changed files with 2,038 additions and 6 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1fca1e5

Please sign in to comment.