Skip to content

Commit

Permalink
fix(rds): Make parameters required
Browse files Browse the repository at this point in the history
  • Loading branch information
aereal committed Mar 24, 2019
1 parent 46b7558 commit ad3d753
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-rds/lib/instance-parameter-group.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export interface InstanceParameterGroupProps {
/**
* The parameters in this parameter group
*/
parameters?: Parameters;
parameters: Parameters;
}

/**
Expand Down
4 changes: 3 additions & 1 deletion packages/@aws-cdk/aws-rds/test/test.cluster.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ export = {
const instanceParameterGroup = new InstanceParameterGroup(stack, 'Params', {
family: 'mysql',
description: 'bye',
parameters: {},
});
instanceParameterGroup.setParameter('param1', 'value1');
instanceParameterGroup.setParameter('param2', 'value2');
Expand Down Expand Up @@ -220,7 +221,8 @@ export = {
const stack = testStack();
const group = new InstanceParameterGroup(stack, 'Params', {
family: 'hello',
description: 'desc'
description: 'desc',
parameters: {},
});

// WHEN
Expand Down

0 comments on commit ad3d753

Please sign in to comment.