-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-ecs-patterns): Integration testing of aws-ecs-patterns contains an invalid integration test #28383
Comments
Yes I see your point. Line 18 in 7c62d68
The Are you interested to submit a PR for that? |
…rgate service (#28463) 1. Fixed the docker image to use Python 3.11 to stop the python3.6 out of date warning/error 2. Fixed the lambda container's entry point handler, causing the integration tests to go into an infinite loop. 3. Fixed/changed the public integration test to a health check test as the queue processing fargate service doesn't have a public-facing feature. Closes #28383. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
…rgate service (aws#28463) 1. Fixed the docker image to use Python 3.11 to stop the python3.6 out of date warning/error 2. Fixed the lambda container's entry point handler, causing the integration tests to go into an infinite loop. 3. Fixed/changed the public integration test to a health check test as the queue processing fargate service doesn't have a public-facing feature. Closes aws#28383. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
The integration testing of the aws-ecs-patterns has an invalid docker being used,
When executed the container state always fails with the following message -
Looking at the docker and python file it never creates a webserver so the test on this location(
aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.queue-processing-fargate-service-public.ts
Line 18 in 7c62d68
It is possible there are other issues with the integration testing but I have found these while working on the bug - aws-ecs-patterns (QueueProcessingFargateService): non-editable Scaling Policy causes race conditions & dropped tasks #20706
Expected Behavior
All integration tests should be perfectly aligned and work as expected.
Current Behavior
Integration tests go into infinite loop until cloud formation tasks fail.
Reproduction Steps
Create a new integration step using the QueueProcessingFargateService, using the same Docker and the index.py with no webserver and the docker should be using the CMD command.
Possible Solution
Additional Information/Context
No response
CDK CLI Version
NA
Framework Version
2.115
Node.js Version
NA
OS
NA
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: